Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

into glob: noop when input is glob #14882

Merged
merged 1 commit into from
Jan 21, 2025
Merged

into glob: noop when input is glob #14882

merged 1 commit into from
Jan 21, 2025

Conversation

Tyarel8
Copy link
Contributor

@Tyarel8 Tyarel8 commented Jan 21, 2025

Description

#14845 (comment)

When the input to into glob is a glob, it will return it like other into commands.

User-Facing Changes

Before, using into glob with a glob as input would return an error, now it will return the input.

132ikl
132ikl approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@132ikl 132ikl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@132ikl 132ikl merged commit 2bd345c into nushell:main Jan 21, 2025
15 checks passed
@github-actions github-actions bot added this to the v0.102.0 milestone Jan 21, 2025
@Tyarel8 Tyarel8 deleted the idem-into-glob branch January 21, 2025 16:15
@fdncred fdncred added the pr:commands This PR changes our commands in some way label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@132ikl 132ikl 132ikl approved these changes

Assignees
No one assigned
Labels
pr:commands This PR changes our commands in some way
Projects
None yet
Milestone
v0.102.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Tyarel8 @132ikl @fdncred