Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retrieval of config directory for user autoloads #14877

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

NotTheDr01ds
Copy link
Contributor

@NotTheDr01ds NotTheDr01ds commented Jan 20, 2025

Description

Fixes an issue with #14669 - I mistakenly used dirs::config_dir() when it should be nu_path::config_dir(). This allows XDG_CONFIG_DIR to specify the location properly.

User-Facing Changes

Fix: If XDG_CONFIG_DIR is set, it will be used for the autoload location.

Tests + Formatting

  • 🟢 toolkit fmt
  • 🟢 toolkit clippy
  • 🟢 toolkit test
  • 🟢 toolkit test stdlib

After Submitting

N/A

@sholderbach sholderbach added configuration Issue related to nu's configuration pr:bugfix This PR fixes some bug labels Jan 20, 2025
@NotTheDr01ds NotTheDr01ds merged commit b97d89a into nushell:main Jan 20, 2025
15 checks passed
@NotTheDr01ds NotTheDr01ds deleted the fix-autoload-config-path branch January 20, 2025 22:49
@github-actions github-actions bot added this to the v0.102.0 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration Issue related to nu's configuration pr:bugfix This PR fixes some bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants