Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename fmt to format number #14875

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Rename fmt to format number #14875

merged 1 commit into from
Jan 21, 2025

Conversation

132ikl
Copy link
Contributor

@132ikl 132ikl commented Jan 20, 2025

Description

This PR renames fmt to format number, to bring it in line with similar value formatting commands and make it more discoverable.

User-Facing Changes

  • The fmt command is now format number. A deprecation warning will be thrown if you use fmt.

Tests + Formatting

  • 🟢 toolkit fmt
  • 🟢 toolkit clippy
  • 🟢 toolkit test
  • 🟢 toolkit test stdlib

After Submitting

N/A

sholderbach
sholderbach approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@sholderbach sholderbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the harmonization and the fact that you also used the pattern of using a single implementation with the reference in the old command with the deprecation

@sholderbach sholderbach added deprecation Related to the deprecation of commands naming-things 🚲 🛖 Working towards consistent naming. No bikeshedding brigade please! labels Jan 20, 2025
@fdncred fdncred added the pr:breaking-change This PR implies a change affecting users and has to be noted in the release notes label Jan 20, 2025
@132ikl
Copy link
Contributor Author

132ikl commented Jan 20, 2025

I just copied your deprecation of into bits to be honest 🤣

WindSoilder
WindSoilder approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@WindSoilder WindSoilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's land it and move forward

@WindSoilder WindSoilder merged commit 0e41868 into nushell:main Jan 21, 2025
15 checks passed
@github-actions github-actions bot added this to the v0.102.0 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WindSoilder WindSoilder WindSoilder approved these changes

@sholderbach sholderbach sholderbach approved these changes

Assignees
No one assigned
Labels
deprecation Related to the deprecation of commands naming-things 🚲 🛖 Working towards consistent naming. No bikeshedding brigade please! pr:breaking-change This PR implies a change affecting users and has to be noted in the release notes
Projects
None yet
Milestone
v0.102.0
Development

Successfully merging this pull request may close these issues.
4 participants
@132ikl @sholderbach @WindSoilder @fdncred