fix range bugs in str substring and str index-of
#14863
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of commands that accept range arguments specifically need IntRange, this reduces the required boilerplate.
`process_range` returns inclusive bounds, which were used as if they were end-exclusive resulting in an off-by-one start bound cast to usize without handling negative values, causing and underflow and resulting in an out of bounds access.
absolute_start_new and absolute_end_new are an implementation detail that will hopefully be folded into existing functions
- fix 0..<0 case - the previous impl's grapheme handling might have been broken in some cases, I didn't confirm this hunch but the new impl is easier to follow and no tests broke
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0..<0#14769Description
FromValueforIntRange, as it is very common to use integer ranges as argumentsIntRange::absolute_startcan now point one-past-endIntRange::absolute_endconverts relativeIncludedbounds to absoluteExcludedboundsIntRange::absolute_boundsis convenience method that calls the otherabsolute_*method and transforms reverse ranges to empty atstart(5..3=>5..<5)str substringtests to allow empty exclusive range tests0..<0case forstr substringandstr index-ofUser-Facing Changes
There should be no noticeable changes other than the bugfix.
Tests + Formatting
After Submitting
N/A