Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛂(frontend) Readers and editors can access share modal #302

Merged
merged 3 commits into from
Oct 4, 2024
Merged

🛂(frontend) Readers and editors can access share modal #302

merged 3 commits into from
Oct 4, 2024

Conversation

AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Oct 3, 2024 •
edited by sampaccoud
Loading

Purpose

Readers and editors of a document can access the share modal and see the list of members and their roles.

Demo

scrnli_10_3_2024_3-33-20.PM.webm

@AntoLC AntoLC self-assigned this Oct 3, 2024
@AntoLC AntoLC marked this pull request as draft October 3, 2024 13:44
@AntoLC AntoLC linked an issue Oct 3, 2024 that may be closed by this pull request
🛂Every roles should see members and invited #192
Closed
@AntoLC AntoLC force-pushed the refacto/all-members-see-each-others branch from cb56278 to 411aa41 Compare October 3, 2024 14:42
@AntoLC AntoLC marked this pull request as ready for review October 3, 2024 14:43
@AntoLC AntoLC force-pushed the refacto/all-members-see-each-others branch from 411aa41 to 5bc9d55 Compare October 3, 2024 14:44
@sampaccoud sampaccoud changed the title 🛂(frontend) viewers and editors can access share modal 🛂(frontend) Readers and editors can access share modal Oct 3, 2024
@AntoLC AntoLC force-pushed the refacto/all-members-see-each-others branch from 5bc9d55 to d341baa Compare October 4, 2024 08:22
@AntoLC AntoLC linked an issue Oct 4, 2024 that may be closed by this pull request
🐛(frontend) Editor break line not working #298
Closed
@AntoLC AntoLC force-pushed the refacto/all-members-see-each-others branch 2 times, most recently from dee95ad to 13bb762 Compare October 4, 2024 08:29
@AntoLC
🛂(frontend) readers and editors can access share modal
b9afb1c 
Readers and editors of a document can access the share
modal and see the list of members and their roles.
@AntoLC
🐛(frontend) fix infinity scroll on invitation list
9d1ea4d 
The infinity scroll had some difficulties to
load the next page of invitations because the ref
could be not init.
This commit fixes the issue.
@AntoLC
⬆️(frontend) upgrade blocknote to 0.16.0
a281ec7 
Version 0.16.0 of Blocknote fixes the breakline issue.
@AntoLC AntoLC force-pushed the refacto/all-members-see-each-others branch from 13bb762 to a281ec7 Compare October 4, 2024 08:40
@AntoLC AntoLC merged commit 647e6c1 into main Oct 4, 2024
16 of 17 checks passed
@AntoLC AntoLC deleted the refacto/all-members-see-each-others branch October 4, 2024 09:04
@AntoLC AntoLC mentioned this pull request Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AntoLC AntoLC

Labels
frontend refacto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛(frontend) Editor break line not working 🛂Every roles should see members and invited
1 participant
@AntoLC