Coremark issues for NCS 3.0.0 #19958
Merged
+29
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 3bac360580b6a8c659c0ac853bd2ed3bc12b31e4 more detailssdk-nrf:
Github labels
List of changed files detected by CI (6)Outputs:ToolchainVersion: 342151af73 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
mkapala-nordic
approved these changes
Jan 17, 2025
Drivers need to be run from non blocking thread. We need preemptive priority during init. Later we prefer cooperative priority to ensure no interference with benchmark. JIRA: NCSDK-30369 Signed-off-by: Jan Zyczkowski <jan.zyczkowski@nordicsemi.no>
zycz
force-pushed
the
coremark_issues_300
branch
from
80a3d5a to
3647f0d
Compare
Add compiler flags to increase performance. JIRA: NCSDK-30665 Signed-off-by: Jan Zyczkowski <jan.zyczkowski@nordicsemi.no>
zycz
force-pushed
the
coremark_issues_300
branch
from
b978017 to
0ca3986
Compare
mkapala-nordic
approved these changes
Jan 17, 2025
MarekPieta
requested changes
Jan 17, 2025
Enable the error level in the CoreMark sample. JIRA: NCSDK-30375 Signed-off-by: Jan Zyczkowski <jan.zyczkowski@nordicsemi.no>
zycz
force-pushed
the
coremark_issues_300
branch
from
0ca3986 to
3bac360
Compare
zycz
removed
the
changelog-entry-required
MarekPieta
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set coremark main thread to cooperative priority at start of main - requirement to allow starting drivers form non-blocking context.
Add extra compiler flags to improve performance.
Change log level to enable seeing errors.