Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(signals): migrate signals testing suite from Jest to Vitest #4631

Merged
merged 9 commits into from
Dec 23, 2024
Merged

test(signals): migrate signals testing suite from Jest to Vitest #4631

merged 9 commits into from
Dec 23, 2024

Conversation

brandonroberts
Copy link
Member

@brandonroberts brandonroberts commented Dec 13, 2024 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe:

What is the current behavior?

Unit tests for the @ngrx/signals package are run with Jest

Closes #4637

What is the new behavior?

  • Unit tests for the @ngrx/signals package are run with Vitest
  • Unit tests for @ngrx/signals schematics are still run in parallel with Jest because of CommonJS

Cold cache comparisons
Jest - 44 seconds to complete all tests
Vitest - 21 seconds to complete all tests

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify Netlify
Copy link

netlify bot commented Dec 13, 2024 •
edited
Loading

✅ Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit dae9f8a
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/67699c86f051c9000802dd85

timdeschryver
timdeschryver reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🤩
There's one test that's skipped, is this intended because it fails?

modules/signals/spec/signal-state.spec.ts Outdated Show resolved Hide resolved
timdeschryver
timdeschryver approved these changes Dec 23, 2024
View reviewed changes
modules/signals/tsconfig.spec.json Outdated Show resolved Hide resolved
@brandonroberts brandonroberts merged commit 5e98142 into main Dec 23, 2024
11 checks passed
@brandonroberts brandonroberts deleted the test-signals-vitest branch December 23, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markostanimirovic markostanimirovic markostanimirovic approved these changes

@timdeschryver timdeschryver timdeschryver approved these changes

@rainerhahnekamp rainerhahnekamp Awaiting requested review from rainerhahnekamp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing: Migrate NgRx Signals Testing Suite from Jest to Vitest
3 participants
@brandonroberts @markostanimirovic @timdeschryver