Skip to content

Commit

Permalink
fix: swapped _R_co and _P to prevent type error. (Lightning-AI#20508)
Browse files Browse the repository at this point in the history
When loading a pytorch-lightning model from MLFlow, I get `TypeError: Type parameter +_R_co without a default follows type parameter with a default`.  This happens whenever doing `import pytorch_lightning as pl` which is done by packages like MLFlow.

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Luca Antiga <luca.antiga@gmail.com>
  • Loading branch information
3 people authored Jan 6, 2025
1 parent efe311c commit ee7fa43
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/lightning/pytorch/utilities/model_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def _check_mixed_imports(instance: object) -> None:
_R_co = TypeVar("_R_co", covariant=True) # return type of the decorated method


class _restricted_classmethod_impl(Generic[_T, _P, _R_co]):
class _restricted_classmethod_impl(Generic[_T, _R_co, _P]):
"""Drop-in replacement for @classmethod, but raises an exception when the decorated method is called on an instance
instead of a class type."""

Expand Down

0 comments on commit ee7fa43

Please sign in to comment.