Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Job to have custom detail views #17266

Closed
amyasnikov opened this issue Aug 26, 2024 · 1 comment
Closed

Allow Job to have custom detail views #17266

amyasnikov opened this issue Aug 26, 2024 · 1 comment
Labels
netbox type: feature Introduction of new functionality to the application

Comments

@amyasnikov
Copy link
Contributor

NetBox version

v4.0.9

Feature type

Change to existing functionality

Proposed functionality

Most of the NetBox models can have custom detail views (and tabs) registered using utilities.views.register_model_view, but core.Job cannot have these custom views because core.urls.urlpatterns lacks of this line:

path('jobs/<int:pk>/', include(get_model_urls('core', 'job')))

I suggest to add the line above to the core.urls.urlpatterns

Use case

With the proposed change plugin maintainers will be allowed to add extra tabs to Job detail view.

Moreover, the proposed change will just put core.Job model in consistency with the most of the other NetBox models which already have the corresponding include lines in the urlpatterns

Database changes

No response

External dependencies

No response

@amyasnikov amyasnikov added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels Aug 26, 2024
@netbox-community netbox-community deleted a comment Aug 26, 2024
@jeremystretch jeremystretch added the netbox label Nov 1, 2024 — with Linear
@jeremystretch
Copy link
Member

I believe this functionality was added in a recent release, so I'm going to close this out. Please feel free to resubmit if you still encounter issues on NetBox v4.2.1 or later.

@jeremystretch jeremystretch removed the status: needs triage This issue is awaiting triage by a maintainer label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
netbox type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

4 participants
@amyasnikov @jeremystretch and others