Add YesorNo Field option for a special char in random password generation, also make sure that special char always present if intended #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FuzzyParrabellum
had a problem deploying
to
test
GitHub Actions
Failure
FuzzyParrabellum
had a problem deploying
to
test
GitHub Actions
Failure
FuzzyParrabellum
had a problem deploying
to
test
GitHub Actions
Failure
FuzzyParrabellum
had a problem deploying
to
test
GitHub Actions
Failure
FuzzyParrabellum
had a problem deploying
to
test
GitHub Actions
Failure
FuzzyParrabellum
had a problem deploying
to
test
GitHub Actions
Failure
FuzzyParrabellum
had a problem deploying
to
test
GitHub Actions
Failure
FuzzyParrabellum
had a problem deploying
to
test
GitHub Actions
Failure
Spitfireap
requested changes
Nov 13, 2024
| certain_chars = '' | ||
| for i in range(10): # limit tries | ||
| if allow_special_characters: # add special characters in random passwd | ||
| possible_chars_types.append(string.punctuation) |
There was a problem hiding this comment.
Aren't you adding it at each try ?
modoboa/admin/tests/test_account.py
Outdated
| @@ -346,6 +346,10 @@ def test_random_password(self): | |||
| "email": "tester@test.com", | |||
| "stepid": "step2", | |||
| } | |||
| # TODO: add test to check if unhashed password created with | |||
There was a problem hiding this comment.
Have you got time to do it ?
…nction make_password
…nclude at least one of the possible string groups (ascii_letters, digits, special characters etc.)
…ng if some characters are in unhashed password before user creation with random password
Spitfireap
force-pushed
the
specialchar_pswdgenerator
branch
from
03585e7 to
09bec2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf issue #3327 - Setting a password policy that requires "special" symbols breaks the random password generator
Before PR, if user wanted to have a special character in their randomly generated password upon user creation, they had to directely change AUTH_PASSWORD_VALIDATORS in settings.py. That behavior could lead to an infinite while loop bug with custom make_password() function in modoboa\modoboa\admin\lib.py.
After PR :