Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[27.x backport] Restore labels when re-creating Windows networks #49200

Merged
merged 1 commit into from
Jan 2, 2025
Merged

[27.x backport] Restore labels when re-creating Windows networks #49200

merged 1 commit into from
Jan 2, 2025

Conversation

robmry
Copy link
Contributor

@robmry robmry commented Jan 2, 2025

- What I did

- How I did it

Save and restore network labels when re-creating Windows networks during daemon startup.

- How to verify it

As described in the issue ...

docker network create --label test --driver nat test
docker network inspect test. Check that the label test has been successfully added.
Restart the Windows service for the docker engine ( or restart the computer to install OS updates)
docker network inspect test. Check if the label test still exists.

- Description for the changelog

- Preserve network labels during daemon startup.

@robmry
Restore labels when re-creating Windows networks
95b2f2e 
Signed-off-by: Rob Murray <rob.murray@docker.com>
(cherry picked from commit 25009ed)
Signed-off-by: Rob Murray <rob.murray@docker.com>
@robmry robmry added this to the 27.5.0 milestone Jan 2, 2025
@robmry robmry self-assigned this Jan 2, 2025
thaJeztah
thaJeztah approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robmry robmry marked this pull request as ready for review January 2, 2025 20:37
@thaJeztah thaJeztah merged commit 9cf3313 into moby:27.x Jan 2, 2025
144 checks passed
thaJeztah added a commit that referenced this pull request Jan 2, 2025
@thaJeztah
Merge pull request #49200 from robmry/backport-27.x/49179_restore_win…
9cf3313 
…dows_network_labels

[27.x backport] Restore labels when re-creating Windows networks
@robmry robmry deleted the backport-27.x/49179_restore_windows_network_labels branch January 3, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees

@robmry robmry

Labels
area/daemon area/networking impact/changelog platform/windows
Projects
None yet
Milestone
27.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@robmry @thaJeztah