remove pkg/broadcaster and make it internal to container/streams #49172
+16
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package was only used internally in container/streams and had no external consumers. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
status/2-code-review
impact/deprecation
kind/refactor
thaJeztah
commented
Dec 28, 2024
Comment on lines
-45
to
+49
| func (c *Config) Stdout() *broadcaster.Unbuffered { | ||
| func (c *Config) Stdout() io.Writer { | ||
| return c.stdout | ||
| } | ||
|
|
||
| // Stderr returns the standard error in the configuration. | ||
| func (c *Config) Stderr() *broadcaster.Unbuffered { | ||
| func (c *Config) Stderr() io.Writer { |
There was a problem hiding this comment.
io.Writer as the extra features provided by Unbuffered were only used internally, not by callers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/pkg#32989This package was only used internally in container/streams and had no external consumers.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)