Remove interactivity-utils #90
Conversation
src/behavior.ts
Outdated
| this.options.legendItems.on("contextmenu", (event: MouseEvent, dataPoint: LegendDataPoint) => { | ||
| event.preventDefault(); | ||
| event.stopPropagation(); | ||
| this.selectionManager.showContextMenu(dataPoint.identity, { | ||
| x: event.clientX, | ||
| y: event.clientY | ||
| }); | ||
| }); |
There was a problem hiding this comment.
I think we can create a callback that gets the identity and event as params and call it here and on the lines 151 and 132
There was a problem hiding this comment.
As you did it below with emptyContextMenu
There was a problem hiding this comment.
The callback is the same for selections and outerline d3-selections, but the legendItems has a little different dataPoint. Identity is retrieved from dataPoint.identity for LegendDataPoint and dataPoint.data.identity for d3PieArcDatum<AsterDataPoint>.
Therefore, I created a callback for d3PieArcDatum as it's duplicated, but leave the callback for LegendDataPoint as it is.
There was a problem hiding this comment.
This is why I said that you can pass an identity instead of dataPoint, so it won't affect on it
No description provided.