fix:TCPInterface: Try connect to both IPv4 & IPv6 #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the problem where if a target host has both an IPv6 and IPv4 address, RNS only connects to the IPv6 address, even if it is down. (target_ip here is sourced from the config file target_host entry, so could also be a hostname, but socket.create_connection will resolve it) Signed-off-by: Kevin Steen <code at kevinsteen.net>
yea that's right, ipv6 is not available right now on this node. working on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed last night that RNS couldn't connect to the Chaosnet node (rns.c3.jitter.eu) IPv6 as it was firewalled and refusing connections, but RNS never tried the IPv4 address.
This change uses the socket.create_connection function to run the Happy Eyeballs procedure of resolving all addresses and trying to connect to them until 1 succeeds.
-Kevin