Use JavaScript's strict mode

No further adaptions necessary, also tested usages of "this" and "call()". Strict mode has been activated for all .js files except index.js because "test main preferences keep" failed with an exception then. Removing "use strict" from test/test-index.js did not fix behaviour.
marcows · May 2, 2019 · 537ce3c · 537ce3c
1 parent ee8eb7f
commit 537ce3c
Showing 13 changed files with 25 additions and 0 deletions.
diff --git a/data/contextmaps.js b/data/contextmaps.js
@@ -2,6 +2,8 @@
  * Content script for the context menu with the destination maps.
  */
 
+"use strict";
+
 /*
  * Handle the event when a context menu item has been clicked.
  */

diff --git a/data/editmaps.js b/data/editmaps.js
@@ -2,6 +2,8 @@
  * UI for configuring and selecting the used destination maps.
  */
 
+"use strict";
+
 var draggedEl;
 
 function handleDragStart(ev)

diff --git a/data/geosite.js b/data/geosite.js
@@ -23,6 +23,8 @@
  * @type {GeositeInfo}
  */
 
+"use strict";
+
 var scanners = [
 	{
 		func: scanGeosite_Wikipedia,

diff --git a/data/geosite/flickr.js b/data/geosite/flickr.js
@@ -2,6 +2,8 @@
  * Part of content script {@link module:data/geosite}.
  */
 
+"use strict";
+
 /*
  * Scanner for Flickr photo site.
  *

diff --git a/data/geosite/geotag.js b/data/geosite/geotag.js
@@ -2,6 +2,8 @@
  * Part of content script {@link module:data/geosite}.
  */
 
+"use strict";
+
 /*
  * Scanner for geo tags.
  *

diff --git a/data/geosite/wikipedia.js b/data/geosite/wikipedia.js
@@ -2,6 +2,8 @@
  * Part of content script {@link module:data/geosite}.
  */
 
+"use strict";
+
 /*
  * Scanner for Wikipedia.
  *

diff --git a/data/geosite/wikivoyage.js b/data/geosite/wikivoyage.js
@@ -2,6 +2,8 @@
  * Part of content script {@link module:data/geosite}.
  */
 
+"use strict";
+
 /*
  * Scanner for Wikivoyage.
  *

diff --git a/data/usemaps.js b/data/usemaps.js
@@ -17,6 +17,7 @@
  * @event pagesize
  */
 
+"use strict";
 
 /**
  * Handle a click on a panel link.

diff --git a/lib/geourl.js b/lib/geourl.js
@@ -4,6 +4,8 @@
  * @module
  */
 
+"use strict";
+
 var parsers = [
 	parseGeoURL_GeoURI,
 	parseGeoURL_OSMnewstyle,

diff --git a/lib/mapcoords.js b/lib/mapcoords.js
@@ -19,6 +19,8 @@
  * @global
  */
 
+"use strict";
+
 // Default osmzoom if no zoom/scale is given
 const DEFAULT_ZOOM = 15;
 

diff --git a/test/test-geourl.js b/test/test-geourl.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var geourl = require("../lib/geourl.js");
 
 var testdata = require("./testurls.json");

diff --git a/test/test-index.js b/test/test-index.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var main = require("../");
 var preferences = require("sdk/simple-prefs");
 

diff --git a/test/test-mapcoords.js b/test/test-mapcoords.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var mapcoords = require("../lib/mapcoords.js");
 
 var testdata = require("./testcoords.json");