Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VarShapeOsc sync flag seems to be backward #38

Open
jamshark70 opened this issue Nov 21, 2023 · 4 comments
Open

VarShapeOsc sync flag seems to be backward #38

jamshark70 opened this issue Nov 21, 2023 · 4 comments

Comments

@jamshark70
Copy link

Describe the bug
Sync flag seems reversed from documentation.

To Reproduce

a = {
	var sig = VarShapeOsc.ar(LFDNoise3.kr(2).exprange(100, 500), 0.5, 0.5, 0);
	(sig * 0.05).dup
}.play;

Expected behavior
With sync disabled (0), we should hear the frequency modulation.

Instead we hear a constant frequency matching the default sync frequency.
@madskjeldgaard
Copy link
Owner

Thanks! I am taking a break from maintaining these plugins but let me know if you want to do a PR :)

@jamshark70
Copy link
Author

OK, I can try a PR. Would you recommend to change the documentation, or the behavior? Backward compatibility seems like it could only be quite odd: an input named sync where 0 = enable, 1 = disable. This will confuse.

@jamshark70
Copy link
Author

BTW my ability to work on the C++ side would be somewhat hampered by:

git clone https://github.com/madskjeldgaard/portedplugins
// OK

cd portedplugins
// OK

git submodule update --init --recursive
// nothing happens

@madskjeldgaard
Copy link
Owner

BTW my ability to work on the C++ side would be somewhat hampered by:

git clone https://github.com/madskjeldgaard/portedplugins
// OK

cd portedplugins
// OK

git submodule update --init --recursive
// nothing happens

Thanks for looking into this, James. There aren't any submodules in the project anymore, I should update the info, sorry about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamshark70 @madskjeldgaard