It seems we should fix the following line

v1.10.0 (FAIL)

https://github.com/lz4/lz4/blob/v1.10.0/lib/Makefile#L126

v1.9.4 (OK)

https://github.com/lz4/lz4/blob/v1.9.4/lib/Makefile#L116

Due to the difference of --out-implib, the following COPY commands in appveyor.yml fail to copy them

https://github.com/lz4/lz4/blob/v1.9.4/appveyor.yml#L69-L70

Full log

mingw.cmd

uname -a
# MINGW64_NT-10.0-22631  3.5.4-0bc1222b.x86_64 2024-09-04 18:28 UTC x86_64 Msys

pacman -Sy  --noconfirm pacman
pacman -Syu --noconfirm
pacman -S   --noconfirm git base-devel $MINGW_PACKAGE_PREFIX-{pkg-config,gcc,clang}

gcc --version
# gcc.exe (Rev1, Built by MSYS2 project) 14.2.0

make --version
# GNU Make 4.4.1

cd $PUBLIC
git clone https://github.com/lz4/lz4.git --branch v1.9.4  --single-branch lz4-v1.9.4
git clone https://github.com/lz4/lz4.git --branch v1.10.0 --single-branch lz4-v1.10.0

( cd lz4-v1.9.4  && make -C lib clean lib V=1 )
( cd lz4-v1.10.0 && make -C lib clean lib V=1 )

ls lz4-v1.9.4/lib/dll
# example  liblz4.dll  liblz4.dll.a

ls lz4-v1.10.0/lib/dll
# example
#          ^^^^^^^^^^  ^^^^^^^^^^^^
#          v1.10.0 doesn't generate {.dll , .a} to lib/dll/

diff lz4-v1.9.4/lib/Makefile lz4-v1.10.0/lib/Makefile | grep "LZ4_DLL_EXPORT.*shared"
# <       $(CC) $(FLAGS) -DLZ4_DLL_EXPORT=1 -shared $^ -o dll/$@.dll -Wl,--out-implib,dll/$(LIBLZ4_EXP)
# >       $(CC) $(ALLFLAGS) -DLZ4_DLL_EXPORT=1 -shared $^ -o $@ -Wl,--out-implib,$(LIBLZ4_EXP)

lz4-1.10.0 Windows releases are missing dlls #1473

Description

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions