Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable for merge commits #319

Open
crittermike opened this issue Sep 20, 2016 · 3 comments
Open

Add option to disable for merge commits #319

crittermike opened this issue Sep 20, 2016 · 3 comments
Labels
feature

Comments

@crittermike
Copy link
Contributor

Is this already possible? I'd like merge commits to not trigger lolcommits to run, since those tend to be completely uninteresting and pointless to document.
@matthutchinson
Copy link
Member

matthutchinson commented Sep 24, 2016 •
edited
Loading

Sorry for the late reply...

This currently isn't possible. But it could be part of a new feature, where you could configure lolcommits to ignore commits with certain keywords in their commit messages, or have it auto-detect when a merge commit was happening - like we do to detect interactive rebase merges in the post-commit hook here.

I'll tag issue as this as a feature request for now

@tigerclaw-az
Copy link

+1

@matthutchinson
Copy link
Member

+1 I agree this should be the default, I'm a little swamped at the minute so I'd welcome any PR that attempts to fix this 😄

@matthutchinson matthutchinson reopened this Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matthutchinson @crittermike @tigerclaw-az