-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How do we handle exceptions that occur? #29
Comments
One idea I have is:
Pros:
Cons:
|
Great place to start: Good way to test this is to go into |
Another idea: Ignore Rx completely. Wrap each call to an abstract function of The nice part about this is to also help with Teller exception handling (when Teller code throws an exception from a bug). When a dev calls a function on Teller code, we can wrap the Teller code in a try/catch block. When an exception is thrown, we can show a message such as "An exception has been thrown within Teller. This is probably a bug. Report that here: github.com/teller/issues/new and paste the below information:....." where the user can give we need to fix it. Exceptions on the dev's code should not interfere because of nested try/catch blocks surrounding dev's code. This issue couples well with the above paragraph. Debug statements can be generated and saved by Teller and dumped to the console when an exception happens. |
iOS has this implemented with a try/catch implementation. See code |
This issue could cover many parts of Teller, but a good place to start is in
OnlineRepository
.Teller is a library that performs actions on behalf of the developer. Network calls, saving data to the device, reading data from the device. All of these functions could throw an exception from the developer's code.
When an exception is raised, what do we do? How should Teller handle it?
The text was updated successfully, but these errors were encountered: