Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RxJava2 and make it an optional, separate module. #1

Open
levibostian opened this issue May 14, 2018 · 2 comments
Open

Remove RxJava2 and make it an optional, separate module. #1

levibostian opened this issue May 14, 2018 · 2 comments
Assignees
@levibostian
Labels
blocked Can't work on this until another issue resolved

Comments

@levibostian
Copy link
Owner

RxJava2 is a library some people may not want to use. I also enjoy creating libraries that do not have dependencies on them if I can help it.

Therefore, let's remove RxJava2 from the core of the library and make it a separate module that devs can use if they wish.
@levibostian
Copy link
Owner Author

levibostian commented Aug 28, 2018 •
edited
Loading

I would like to create a LiveData version of the library as well.

For the LiveData version, for observe() in the OnlineRepository, make sure that it is generic enough that you can do whatever you want here. Returning LiveData<generic> should do that as LiveData is abstract already.

@levibostian
Copy link
Owner Author

Waiting on this issue as it will more then likely make this much easier to do.

@levibostian levibostian added the blocked Can't work on this until another issue resolved label Oct 14, 2019
@levibostian levibostian mentioned this issue Mar 24, 2020
Open
@levibostian levibostian pinned this issue Aug 6, 2020
@levibostian levibostian self-assigned this Aug 6, 2020
@levibostian levibostian unpinned this issue Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@levibostian levibostian

Labels
blocked Can't work on this until another issue resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@levibostian