CodSpeed Performance Report

Merging #5555 will degrade performances by 58.3%

_{Comparing MarceloNunesAlves:fix/db_async_driver (fc82703) with main (16ff8eb)}

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Does it work ? I think to use mysql+aiomysql, you need the aiomysql package to be installed which is not the case in the default LangFlow.

Does it work ? I think to use mysql+aiomysql, you need the aiomysql package to be installed which is not the case in the default LangFlow.

Yes! You need to install the driver of your choice. And I did it this way because it is generic for other DB, such as Oracle and SQLServer.
I think the idea of the project has always been to allow the use of any relational database. And frankly, the way this method works with these different conditional structures, I don't think it's the most appropriate. but I kept it so as not to harm others who already use this version in production.

I tried this solution . it doesn't work. this Exception is still raised.

sqlalchemy.exc.MissingGreenlet: greenlet_spawn has not been called; can't call await_only() here. Was IO attempted in an unexpected place? (Background on this error at: https://sqlalche.me/e/20/xd2s)

I tried this solution . it doesn't work. this Exception is still raised.

sqlalchemy.exc.MissingGreenlet: greenlet_spawn has not been called; can't call await_only() here. Was IO attempted in an unexpected place? (Background on this error at: https://sqlalche.me/e/20/xd2s)

OK! What did you put in the environment variables: LANGFLOW DATABASE_URL and LANGFLOW_DATABASE_DRIVER_ASYNC? Have you tested with my branch?

I tried this solution . it doesn't work. this Exception is still raised.

sqlalchemy.exc.MissingGreenlet: greenlet_spawn has not been called; can't call await_only() here. Was IO attempted in an unexpected place? (Background on this error at: https://sqlalche.me/e/20/xd2s)

OK! What did you put in the environment variables: LANGFLOW DATABASE_URL and LANGFLOW_DATABASE_DRIVER_ASYNC? Have you tested with my branch?

I tried it on Windows 11 . I installed the langflow 1.1.1 and then I merge your code in it . Then I run it with this command:

python -m langflow run --env-file=.env

in the .envfile . I set the environment variables as follow:

LANGFLOW_DATABASE_DRIVER_ASYNC=mysql+aiomysql
LANGFLOW_DATABASE_URL=mysql+aiomysql://{my_user}:{mypassword}@{my_ip}:{my_port}/langflow_newest_dev

I tried this solution . it doesn't work. this Exception is still raised.

sqlalchemy.exc.MissingGreenlet: greenlet_spawn has not been called; can't call await_only() here. Was IO attempted in an unexpected place? (Background on this error at: https://sqlalche.me/e/20/xd2s)

OK! What did you put in the environment variables: LANGFLOW DATABASE_URL and LANGFLOW_DATABASE_DRIVER_ASYNC? Have you tested with my branch?

I tried it on Windows 11 . I installed the langflow 1.1.1 and then I merge your code in it . Then I run it with this command:

python -m langflow run --env-file=.env

in the .envfile . I set the environment variables as follow:

LANGFLOW_DATABASE_DRIVER_ASYNC=mysql+aiomysql
LANGFLOW_DATABASE_URL=mysql+aiomysql://{my_user}:{mypassword}@{my_ip}:{my_port}/langflow_newest_dev

I fixed it. the engine mysql+aiomysql is not available to function inspect and run_migrations_online . we should use mysql+pymysql

@qq745639151,

Yes! That's why I asked you for both configurations, because one must use mysql+pymysql (For the non-asynchronous engine) and mysql+aiomysql (For the asynchronous engine). In your case the configuration would be like this:

LANGFLOW_DATABASE_DRIVER_ASYNC=mysql+aiomysql
LANGFLOW_DATABASE_URL=mysql+pymysql://{my_user}:{mypassword}@{my_ip}:{my_port}/langflow_newest_dev

@qq745639151,

Yes! That's why I asked you for both configurations, because one must use mysql+pymysql (For the non-asynchronous engine) and mysql+aiomysql (For the asynchronous engine). In your case the configuration would be like this:

LANGFLOW_DATABASE_DRIVER_ASYNC=mysql+aiomysql LANGFLOW_DATABASE_URL=mysql+pymysql://{my_user}:{mypassword}@{my_ip}:{my_port}/langflow_newest_dev

OK， Thank you for your help ! I understand it.

@qq745639151,
Yes! That's why I asked you for both configurations, because one must use mysql+pymysql (For the non-asynchronous engine) and mysql+aiomysql (For the asynchronous engine). In your case the configuration would be like this:
LANGFLOW_DATABASE_DRIVER_ASYNC=mysql+aiomysql LANGFLOW_DATABASE_URL=mysql+pymysql://{my_user}:{mypassword}@{my_ip}:{my_port}/langflow_newest_dev

OK， Thank you for your help ! I understand it.

the engine problem is solved. there is another problem .

sqlalchemy.exc.OperationalError: (pymysql.err.OperationalError) (1170, "BLOB/TEXT column 'description' used in key specification without a key length")
[SQL: CREATE INDEX ix_flow_description ON flow (description)]

I fixed it in 260dbcc8b680_adds_tables.py
first import text

from sqlalchemy.sql.expression import text

then change the code in line 116:
the origin code:

batch_op.create_index(batch_op.f("ix_flow_description"), ["description"], unique=False)

the modified code

batch_op.create_index(batch_op.f("ix_flow_description"),[text("description(10)")], unique=False)

I specified a length for the description column. but I don't know if that length is appropriate for the index.