Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): Rename Parse Data component to Data to Message #5547

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

raphaelchristi
Copy link
Contributor

Description

This PR renames the "Parse Data" component to "Data to Message" and updates its icon to better reflect its core functionality of converting data into message format.

Changes Made

  • Changed display name from "Parse Data" to "Data to Message"
  • Updated icon from "braces" to "message-square" to better represent the message output format

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 5, 2025
@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Jan 5, 2025
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Jan 5, 2025
Copy link

codspeed-hq bot commented Jan 5, 2025

CodSpeed Performance Report

Merging #5547 will degrade performances by 94.6%

Comparing raphaelchristi:feat/rename-parse-data-to-message (43d3368) with main (16ff8eb)

Summary

❌ 2 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main raphaelchristi:feat/rename-parse-data-to-message Change
test_get_and_cache_all_types_dict 1 ms 1.6 ms -34.64%
test_successful_run_with_output_type_any 260.3 ms 4,824.7 ms -94.6%

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @raphaelchristi !
Just one minor fix and this should be good to go.

description = "Convert Data into plain text following a specified template."
icon = "braces"
display_name = "Data to Message"
description = "Convert Data objects into chat messages using any {field_name} from input data."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "Convert Data objects into chat messages using any {field_name} from input data."
description = "Convert Data objects into Messages using any {field_name} from input data."

@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Maintenance tasks and housekeeping size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants