-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow flow name to be edited from the main page or by clicking header #5525
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add tests to validate this change?
I think It can be on core tests > extended > features
src/frontend/src/components/core/appHeaderComponent/components/FlowMenu/index.tsx
Outdated
Show resolved
Hide resolved
src/frontend/src/components/core/appHeaderComponent/components/FlowMenu/index.tsx
Outdated
Show resolved
Hide resolved
src/frontend/src/components/core/appHeaderComponent/components/FlowMenu/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…/FlowMenu/index.tsx Co-authored-by: Cristhian Zanforlin Lousa <cristhian.lousa@gmail.com>
…/FlowMenu/index.tsx Co-authored-by: Cristhian Zanforlin Lousa <cristhian.lousa@gmail.com>
…/FlowMenu/index.tsx Co-authored-by: Cristhian Zanforlin Lousa <cristhian.lousa@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
editing the flow name directly in the header inside the flow is not working
This pull request introduces several enhancements and new features to the flow management components in the frontend. The key changes include the addition of an inline flow name editing feature, improvements to the flow settings modal, and updates to the dropdown component to support editing flow details.
Inline Flow Name Editing:
MenuBar
component. This includes the use ofuseEffect
,useState
,useRef
, and event handlers for input changes and key events. (src/frontend/src/components/core/appHeaderComponent/components/FlowMenu/index.tsx
) [1] [2] [3] [4] [5] [6] [7] [8]Flow Settings Modal Enhancements:
FlowSettingsModal
component to acceptflowData
as a prop and updated the state initialization and handlers to use this prop. This allows the modal to be reused with different flow data. (src/frontend/src/modals/flowSettingsModal/index.tsx
) [1] [2]Dropdown Component Updates:
handleEdit
prop to theDropdownComponent
and updated theuseSelectOptionsChange
hook to handle the "edit" action. This enables the dropdown menu to trigger the flow settings modal for editing flow details. (src/frontend/src/pages/MainPage/components/dropdown/index.tsx
,src/frontend/src/pages/MainPage/hooks/use-select-options-change.tsx
) [1] [2] [3] [4] [5]Integration with Grid and List Components:
GridComponent
andListComponent
. This includes adding state for the modal and passing thehandleEdit
function to the dropdown component. (src/frontend/src/pages/MainPage/components/grid/index.tsx
,src/frontend/src/pages/MainPage/components/list/index.tsx
) [1] [2] [3] [4] [5] [6] [7] [8]Type Definitions:
FlowSettingsPropsType
to include an optionalflowData
property, allowing the flow settings modal to be more flexible. (src/frontend/src/types/components/index.ts
)