fix: Improve data consistency in update_flow function #5516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d in the database during flow update 📝 (flows.py): Improve error handling and rollback database session in case of exceptions during flow update 📝 (flows.py): Refactor code to handle unique constraint errors and provide more informative error messages 📝 (utils.py): Refactor get_webhook_component_in_flow function to handle cases where flow_data may not have 'nodes' attribute
dosubot
bot
added
size:M
github-actions
bot
added
bug
github-actions
bot
added
bug
CodSpeed Performance ReportMerging #5516 will improve performances by 26.12%Comparing Summary
Benchmarks breakdown
|
…r folder buttons for improved accessibility and testing ✨ (general-bugs-move-flow-from-folder.spec.ts): add test to ensure user can move flow from one folder to another in the frontend application
…-ai/langflow into cz/fix-move-flow-folder
github-actions
bot
added
bug
github-actions
bot
added
bug
ogabrielluiz
requested changes
Jan 3, 2025
…l data inconsistency ♻️ (service.py): refactor with_session method to handle session commit and rollback more effectively
…-ai/langflow into cz/fix-move-flow-folder
github-actions
bot
added
bug
github-actions
bot
added
bug
github-actions
bot
added
bug
github-actions
bot
added
bug
github-actions
bot
added
bug
italojohnny
force-pushed
the
cz/fix-move-flow-folder
branch
from
c936ebb to
b0cd684
Compare
github-actions
bot
added
bug
github-actions
bot
added
bug
dosubot
bot
added
size:L
github-actions
bot
added
bug
italojohnny
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
update_flowfunction and a utility function in the backend of the Langflow API. The modifications aim to improve error handling, ensure data integrity, and enhance functionality.Improvements to
update_flowfunction:flow.datatodb_flow.dataif it isNoneto ensure data consistency.db_flowafter committing the session, ensuring the updated flow is returned.exceptblock to handle errors more gracefully and ensure the database state is not corrupted.Enhancements to utility function:
flow_datato prevent potential attribute errors in theget_webhook_component_in_flowfunction.