langgraph[patch]: allow ToolNode to ignore ToolCalls for unknown tools #3124
Conversation
| assert isinstance(tools, Sequence) # sequence of BaseTool | ||
| tool_node_names = [] | ||
| for tool in tools: | ||
| tool_node = ToolNode(tools=[tool], ignore_unknown_tool_calls=True) |
There was a problem hiding this comment.
why do we want ignore_unknown_tool_calls=True by default?
also, we should add some validation in case someone tries to pass a ToolNode and also use "v2". we should probably have some of this conditional logic be done earlier as well around line 595 so we don't re-define ToolNode several times
There was a problem hiding this comment.
This loop is creating ToolNodes, and if you have multiple ToolNodes, you likely want ignore_unknown_tool_calls=True.
ToolNode as its implemented now is assuming that each "messages" key is handled by one ToolNode (I think). When ToolNode plucks the last AIMessage with tool calls, it will generate one ToolMessage per tool call -- if there are tools it isn't initialized with, it will generate a placeholder ToolMessage.
Roger on the early validation
There was a problem hiding this comment.
i wonder if it's better to rewrap this into separate, new AI messages (or handle tool calls directly in the tool node), otherwise it's gonna be weird in tracing i think
Alternative to #3126