all is double now, and clarifying comment

klocs · Dec 2, 2019 · e82c6ec · e82c6ec
1 parent ea8a8ee
commit e82c6ec
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/xs/src/libslic3r/TransformationMatrix.cpp b/xs/src/libslic3r/TransformationMatrix.cpp
@@ -277,8 +277,6 @@ TransformationMatrix TransformationMatrix::mat_rotation(double angle_rad, const
 
 TransformationMatrix TransformationMatrix::mat_rotation(Vectorf3 origin, Vectorf3 target)
 {
-    // TODO: there is a lot of float <-> double conversion going on here
-
     TransformationMatrix mat;
     double length_sq = origin.x*origin.x + origin.y*origin.y + origin.z*origin.z;
     double rec_length;
@@ -333,7 +331,7 @@ TransformationMatrix TransformationMatrix::mat_rotation(Vectorf3 origin, Vectorf
         }
     }
     else
-    {// not colinear, cross represents rotation axis so that angle is positive
+    {// not colinear, cross represents rotation axis so that angle is (0, 180)
         // dot's vectors have previously been normalized, so nothing to do except arccos
         double angle = acos(dot);