Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix useDebounceCallback isPending logic #610

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

fix: fix useDebounceCallback isPending logic #610

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d7de92b
fix: fix useDebounceCallback isPending logic
PeterChen1997 Jun 27, 2024
79b4f31
Update useDebounceCallback.ts
PeterChen1997 Jul 5, 2024
8830a1e
Update useDebounceCallback.ts
PeterChen1997 Jul 5, 2024
87e5d63
Update useDebounceCallback.ts
PeterChen1997 Jul 5, 2024
9b7533d
Update useDebounceCallback.ts
PeterChen1997 Jul 5, 2024
7a4ea9b
fix: add try finally block
PeterChen1997 Aug 6, 2024
f282287
feat: add changeset
PeterChen1997 Aug 6, 2024
29002a5
Add tests for useDebounceCallback
simon-lammes Aug 7, 2024
02eca40
add test to verify that debounced callbacks are NOT canceled as this …
simon-lammes Aug 7, 2024
a361251
Merge pull request #1 from simon-lammes/patch-2
PeterChen1997 Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests for useDebounceCallback 
that test the `isPending` behavior
  • Loading branch information
@simon-lammes
simon-lammes authored Aug 7, 2024
commit 29002a5abe21270d329ad14b0bc837f183dcddf4
41 changes: 41 additions & 0 deletions packages/usehooks-ts/src/useDebounceCallback/useDebounceCallback.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,4 +107,45 @@ describe('useDebounceCallback()', () => {
// The callback should be invoked immediately after flushing
expect(debouncedCallback).toHaveBeenCalled()
})

it('should update isPending on invocations', () => {
const delay = 100
const callback = vitest.fn()
const { result } = renderHook(() => useDebounceCallback(callback, delay))

act(() => {
result.current('test1')
result.current('test2')
})

expect(result.current.isPending()).toBeTruthy()

// Fast-forward time
vitest.advanceTimersByTime(200)

expect(result.current.isPending()).toBeFalsy()
})

it('should update isPending on invocations even if callback errors out', () => {
const delay = 100
const errorMessage =
'Mock implementation throws error for testing purposes.'
const callback = vitest.fn().mockImplementation(() => {
throw new Error(errorMessage)
})
const { result } = renderHook(() => useDebounceCallback(callback, delay))

act(() => {
result.current('test1')
result.current('test2')
})

expect(result.current.isPending()).toBeTruthy()

// Forwarding time will invoke the debounced mock function which throws an error.
expect(() => vitest.advanceTimersByTime(200)).toThrowError(errorMessage)

// Even though the mock implementation threw an error, isPending should still be updated to false.
expect(result.current.isPending()).toBeFalsy()
})
})