Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated nhdplus aws web location #87

Merged
merged 3 commits into from
Jul 28, 2022
Merged

updated nhdplus aws web location #87

merged 3 commits into from
Jul 28, 2022

Conversation

vlahm
Copy link
Contributor

@vlahm vlahm commented Jul 28, 2022

@jsta there's one more aws call in R/get.R, which I did not test.

@jsta
Copy link
Owner

jsta commented Jul 28, 2022 •
edited
Loading

Thanks for this! As I recall, I have the downloading functions turned off skip_on_ci in ghactions. Was your testing local?

@vlahm
Copy link
Contributor Author

vlahm commented Jul 28, 2022

Yes, get_plus_remotepath is turned off. I did test locally.

@jsta jsta merged commit dbfef9c into jsta:master Jul 28, 2022
@jsta jsta mentioned this pull request Jul 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlahm @jsta