New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

es5 63行 #10

Open

warmWarmHeart opened this issue Dec 27, 2019 · 1 comment

Assignees

warmWarmHeart commented Dec 27, 2019

es5.js 第63行是否有问题呢？
个人感觉 key.type === 'Identifier'的情况可能是：
let a = 'key1'
let b = {
[a]: '123'
}

这里b中 [a]的key.type就是Identifier 所以key取值应该也得从scope中获取

Owner

jrainlau commented Dec 28, 2019

是的，这里对于 scope 的控制，以及对于变量的取值范围并没有做好，还有很大的优化空间……

jrainlau self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment