Skip to content

Commit

Permalink
modify git edits to make webpack not be stupid (microsoft#10442)
Browse files Browse the repository at this point in the history
  • Loading branch information
Anthony Dresser authored May 15, 2020
1 parent b83279c commit e0bdfc8
Showing 1 changed file with 5 additions and 10 deletions.
15 changes: 5 additions & 10 deletions extensions/git/src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import * as nls from 'vscode-nls';
const localize = nls.loadMessageBundle();

import { ExtensionContext, workspace, window, Disposable, commands, OutputChannel } from 'vscode'; // {{SQL CARBON EDIT}} - remove unused imports
import { ExtensionContext, workspace, window, Disposable, commands, OutputChannel, Uri } from 'vscode';
import { findGit, Git, IGit } from './git';
import { Model } from './model';
import { CommandCenter } from './commands';
Expand Down Expand Up @@ -78,7 +78,7 @@ async function createModel(context: ExtensionContext, outputChannel: OutputChann
new GitTimelineProvider(model)
);

await checkGitVersion(info);
// await checkGitVersion(info); {{SQL CARBON EDIT}} Don't check git version

return model;
}
Expand Down Expand Up @@ -180,13 +180,8 @@ export async function activate(context: ExtensionContext): Promise<GitExtension>
return result;
}

async function checkGitVersion(_info: IGit): Promise<void> { // {{SQL CARBON EDIT}} - Rename info to _info to prevent error due to unused variable
return; /* {{SQL CARBON EDIT}} return immediately
/*const config = workspace.getConfiguration('git');
const shouldIgnore = config.get<boolean>('ignoreLegacyWarning') === true;
// @ts-expect-error
async function checkGitVersion(info: IGit): Promise<void> {
const config = workspace.getConfiguration('git');
const shouldIgnore = config.get<boolean>('ignoreLegacyWarning') === true;

Expand All @@ -211,5 +206,5 @@ async function checkGitVersion(_info: IGit): Promise<void> { // {{SQL CARBON EDI
commands.executeCommand('vscode.open', Uri.parse('https://git-scm.com/'));
} else if (choice === neverShowAgain) {
await config.update('ignoreLegacyWarning', true, true);
}*/
}
}

0 comments on commit e0bdfc8

Please sign in to comment.