Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SystemT instead of System in runGC type signature #128

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Use SystemT instead of System in runGC type signature #128

merged 1 commit into from
Feb 4, 2024

Conversation

jship
Copy link
Collaborator

@jship jship commented Feb 3, 2024

runGC's type signature was previously constrained to System w ().

@jonascarpay jonascarpay self-requested a review February 4, 2024 16:10
jonascarpay
jonascarpay approved these changes Feb 4, 2024
View reviewed changes
Copy link
Owner

@jonascarpay jonascarpay left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks! I've made you a maintainer, feel free to merge once CI is green

@jship jship merged commit 25d7de9 into jonascarpay:master Feb 4, 2024
19 checks passed
@jship jship deleted the runGC-type branch February 4, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonascarpay jonascarpay jonascarpay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jship @jonascarpay