[mypyc] Add primitives for list.sort() and list.reverse() (python#9897)

Adding these since they are trivial to implement.
johnjohndoe · Jan 10, 2021 · 3497675 · 3497675
1 parent a4a5fd6
commit 3497675
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 1 deletion.
diff --git a/mypyc/doc/list_operations.rst b/mypyc/doc/list_operations.rst
@@ -53,8 +53,11 @@ Methods
 
 * ``lst.append(item)``
 * ``lst.extend(x: Iterable)``
-* ``lst.pop()``
+* ``lst.insert(index, item)``
+* ``lst.pop(index=-1)``
 * ``lst.count(item)``
+* ``lst.reverse()``
+* ``lst.sort()``
 
 Functions
 ---------

diff --git a/mypyc/primitives/list_ops.py b/mypyc/primitives/list_ops.py
@@ -113,6 +113,22 @@
     c_function_name='CPyList_Insert',
     error_kind=ERR_NEG_INT)
 
+# list.sort()
+method_op(
+    name='sort',
+    arg_types=[list_rprimitive],
+    return_type=c_int_rprimitive,
+    c_function_name='PyList_Sort',
+    error_kind=ERR_NEG_INT)
+
+# list.reverse()
+method_op(
+    name='reverse',
+    arg_types=[list_rprimitive],
+    return_type=c_int_rprimitive,
+    c_function_name='PyList_Reverse',
+    error_kind=ERR_NEG_INT)
+
 # list * int
 binary_op(
     name='*',

diff --git a/mypyc/test-data/fixtures/ir.py b/mypyc/test-data/fixtures/ir.py
@@ -144,6 +144,7 @@ def count(self, T) -> int: pass
     def extend(self, l: Iterable[T]) -> None: pass
     def insert(self, i: int, x: T) -> None: pass
     def sort(self) -> None: pass
+    def reverse(self) -> None: pass
 
 class dict(Mapping[K, V]):
     @overload

diff --git a/mypyc/test-data/run-lists.test b/mypyc/test-data/run-lists.test
@@ -129,6 +129,26 @@ def test_insert() -> None:
         else:
             assert False
 
+def test_sort() -> None:
+    l = [1, 4, 3, 6, -1]
+    l.sort()
+    assert l == [-1, 1, 3, 4, 6]
+    l.sort()
+    assert l == [-1, 1, 3, 4, 6]
+    l = []
+    l.sort()
+    assert l == []
+
+def test_reverse() -> None:
+    l = [1, 4, 3, 6, -1]
+    l.reverse()
+    assert l == [-1, 6, 3, 4, 1]
+    l.reverse()
+    assert l == [1, 4, 3, 6, -1]
+    l = []
+    l.reverse()
+    assert l == []
+
 [case testListOfUserDefinedClass]
 class C:
     x: int