Only commit undo groups when buffer was modified

This fixes an interaction with kak-lsp that would trigger undo group commit when setting a buffer option value.
jennyb2911 · Sep 12, 2018 · d3be78c · d3be78c
1 parent beb5d00
commit d3be78c
Showing 6 changed files with 12 additions and 1 deletion.
diff --git a/src/context.cc b/src/context.cc
@@ -211,7 +211,11 @@ Vector<String> Context::selections_content() const
 void Context::begin_edition()
 {
     if (m_edition_level >= 0)
+    {
+        if (m_edition_level == 0)
+            m_edition_timestamp = buffer().timestamp();
         ++m_edition_level;
+    }
 }
 
 void Context::end_edition()
@@ -220,7 +224,8 @@ void Context::end_edition()
         return;
 
     kak_assert(m_edition_level != 0);
-    if (m_edition_level == 1)
+    if (m_edition_level == 1 and
+        buffer().timestamp() != m_edition_timestamp)
         buffer().commit_undo_group();
 
     --m_edition_level;

diff --git a/src/context.hh b/src/context.hh
@@ -134,6 +134,7 @@ private:
     void begin_edition();
     void end_edition();
     int m_edition_level = 0;
+    size_t m_edition_timestamp = 0;
 
     friend struct ScopedEdition;
 

diff --git a/test/regression/0-spurious-undo-group-on-external/cmd b/test/regression/0-spurious-undo-group-on-external/cmd
@@ -0,0 +1 @@
+Abarbaz<esc>u
diff --git a/test/regression/0-spurious-undo-group-on-external/in b/test/regression/0-spurious-undo-group-on-external/in
@@ -0,0 +1 @@
+foo
diff --git a/test/regression/0-spurious-undo-group-on-external/out b/test/regression/0-spurious-undo-group-on-external/out
@@ -0,0 +1 @@
+foo
diff --git a/test/regression/0-spurious-undo-group-on-external/rc b/test/regression/0-spurious-undo-group-on-external/rc
@@ -0,0 +1,2 @@
+decl int my_option
+hook global InsertChar r %{ eval -buffer %val{buffile} %{ eval "set buffer my_option 1" } }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		decl int my_option
		hook global InsertChar r %{ eval -buffer %val{buffile} %{ eval "set buffer my_option 1" } }