Require recursive flag to delete directories

jcruzcruz · Feb 6, 2016 · bc5809b · bc5809b
1 parent d8a9719
commit bc5809b
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 5 deletions.
diff --git a/drive/delete.go b/drive/delete.go
@@ -8,19 +8,24 @@ import (
 type DeleteArgs struct {
     Out io.Writer
     Id string
+    Recursive bool
 }
 
-func (self *Drive) Delete(args DeleteArgs) (err error) {
-    f, err := self.service.Files.Get(args.Id).Fields("name").Do()
+func (self *Drive) Delete(args DeleteArgs) error {
+    f, err := self.service.Files.Get(args.Id).Fields("name", "mimeType").Do()
     if err != nil {
         return fmt.Errorf("Failed to get file: %s", err)
     }
 
+    if isDir(f) && !args.Recursive {
+        return fmt.Errorf("'%s' is a directory, use the 'recursive' flag to delete directories", f.Name)
+    }
+
     err = self.service.Files.Delete(args.Id).Do()
     if err != nil {
         return fmt.Errorf("Failed to delete file: %s", err)
     }
 
-    fmt.Fprintf(args.Out, "Removed file '%s'\n", f.Name)
-    return
+    fmt.Fprintf(args.Out, "Deleted '%s'\n", f.Name)
+    return nil
 }
diff --git a/gdrive.go b/gdrive.go
@@ -321,11 +321,19 @@ func main() {
             },
         },
         &cli.Handler{
-            Pattern: "[global] delete <id>",
+            Pattern: "[global] delete [options] <id>",
             Description: "Delete file or directory",
             Callback: deleteHandler,
             Flags: cli.Flags{
                 "global": globalFlags,
+                "options": []cli.Flag{
+                    cli.BoolFlag{
+                        Name: "recursive",
+                        Patterns: []string{"-r", "--recursive"},
+                        Description: "Delete directory and all it's content",
+                        OmitValue: true,
+                    },
+                },
             },
         },
         &cli.Handler{

diff --git a/handlers_drive.go b/handlers_drive.go
@@ -225,6 +225,7 @@ func deleteHandler(ctx cli.Context) {
     err := newDrive(args).Delete(drive.DeleteArgs{
         Out: os.Stdout,
         Id: args.String("id"),
+        Recursive: args.Bool("recursive"),
     })
     checkErr(err)
 }