Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Android sound code issues reported by Codacy #2570

Open
ann0see opened this issue Mar 31, 2022 · 10 comments
Open

Investigate Android sound code issues reported by Codacy #2570

ann0see opened this issue Mar 31, 2022 · 10 comments
Labels
android Android runtime issue bug Something isn't working

Comments

@ann0see
Copy link
Member

ann0see commented Mar 31, 2022

Describe the bug

Codacy complains that the following variable is not used (and I don't see that this is false):

QString latencyMode = ( stream->getPerformanceMode() == oboe::PerformanceMode::None ? "None" : "Power Saving" );

Also this warning:
image

I assume this is a false positive?
To Reproduce

See https://app.codacy.com/gh/ann0see/jamulus/file/68862695471/issues/source?bid=21822857&fileBranchId=21822857

Expected behavior

No Codacy warnings

Screenshots

See above

Operating system

Android

Version of Jamulus

Latest

Additional context

@j-santander @sthenos could you please have a look at these warnings too?

@ann0see ann0see added the bug Something isn't working label Mar 31, 2022
@pgScorpio
Copy link
Contributor

I assume this is a false positive?

No it isn't, but it is not a real issue since it will always be initialized before starting Sound.

(And I'm still hoping to get my sound-redesign implemented, since it will solve a lot of these sound related issues ;=))

@ann0see ann0see added this to Tracking Jul 1, 2023
@github-project-automation github-project-automation bot moved this to Triage in Tracking Jul 1, 2023
@pljones pljones moved this from Triage to Backlog in Tracking Aug 12, 2023
@pljones pljones added this to the Release 3.11.0 milestone Aug 12, 2023
@pljones
Copy link
Collaborator

pljones commented Aug 12, 2023

If this is simple, we might as well try to resolve it in 3.11.0.

@pljones
Copy link
Collaborator

pljones commented Aug 19, 2023

@ann0see I'm happy to pick this one up, unless you're planning to?

@ann0see
Copy link
Member Author

ann0see commented Aug 20, 2023

Feel free to do so. It should be a quick fix.

@pljones pljones self-assigned this Aug 20, 2023
@pljones
Copy link
Collaborator

pljones commented Aug 28, 2023

latencyMode appears not to exist:

$ grep latencyMode android/*.* src/*.*
$

iOboeBufferSizeMono appears not to exist:

$ grep iOboeBufferSizeMono android/*.* src/*.*
$

Where on Github do I look to see Codacity output - is this on jamulussoftware/jamulus:main?

@ann0see
Copy link
Member Author

ann0see commented Aug 28, 2023

Where on Github do I look to see Codacity output - is this on jamulussoftware/jamulus:main?

No. It's just enabled for my repo for security reasons: https://app.codacy.com/gh/ann0see/jamulus/dashboard

@pljones
Copy link
Collaborator

pljones commented Aug 29, 2023

Given anyone can enable Codacity against Jamulus, I don't understand how there is any security benefit in not running the tool on each commit and reporting the findings as part of the build? We use CodeQL in a similar manner - that also reports potential security flaws.

@ann0see
Copy link
Member Author

ann0see commented Aug 29, 2023

Codacy is an external proprietary tool while CodeQL is something supported by GitHub. Every plug-in in the official repo is another potential attack vector.

@pljones
Copy link
Collaborator

pljones commented Aug 29, 2023

That doesn't answer my point. If anyone can use Codacity to expose flaws in Jamulus, should the Jamulus team not take on responsibility by having the reports delivered to the team as part of each build? Either there's a use for the tool, or there isn't, right?

@ann0see
Copy link
Member Author

ann0see commented Aug 29, 2023

Yes. This is true. We can enable Codacy for the repo. We just didn't as it is a proprietary tool.

@pljones pljones removed their assignment May 3, 2024
@pljones pljones moved this from Backlog to Triage in Tracking May 3, 2024
@pljones pljones removed this from the Release 3.11.0 milestone May 3, 2024
@pljones pljones added the android Android runtime issue label Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Android runtime issue bug Something isn't working
Projects
Status: Triage
Development

No branches or pull requests

3 participants