Don't raise an exception on an empty query

j5int · May 21, 2022 · 857252c · 857252c
1 parent 4d8f27f
commit 857252c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 10 deletions.
diff --git a/pg8000/core.py b/pg8000/core.py
@@ -379,7 +379,7 @@ def handle_ERROR_RESPONSE(self, data, context):
         context.error = DatabaseError(msg)
 
     def handle_EMPTY_QUERY_RESPONSE(self, data, context):
-        context.error = DatabaseError("query was empty")
+        pass
 
     def handle_CLOSE_COMPLETE(self, data, context):
         pass

diff --git a/test/dbapi/test_query.py b/test/dbapi/test_query.py
@@ -246,10 +246,9 @@ def test_tpc_prepare(con):
     con.tpc_rollback(xid)
 
 
-# An empty query should raise a ProgrammingError
 def test_empty_query(cursor):
-    with pytest.raises(pg8000.dbapi.DatabaseError):
-        cursor.execute("")
+    """No exception thrown"""
+    cursor.execute("")
 
 
 # rolling back when not in a transaction doesn't generate a warning

diff --git a/test/legacy/test_query.py b/test/legacy/test_query.py
@@ -261,10 +261,9 @@ def test_tpc_prepare(con):
     con.tpc_rollback(xid)
 
 
-# An empty query should raise a ProgrammingError
 def test_empty_query(cursor):
-    with pytest.raises(pg8000.ProgrammingError):
-        cursor.execute("")
+    """No exception raised"""
+    cursor.execute("")
 
 
 # rolling back when not in a transaction doesn't generate a warning

diff --git a/test/native/test_query.py b/test/native/test_query.py
@@ -153,10 +153,9 @@ def test_in(con):
     assert ret[0][0] == "bool"
 
 
-# An empty query should raise a ProgrammingError
 def test_empty_query(con):
-    with pytest.raises(DatabaseError):
-        con.run("")
+    """No exception thrown"""
+    con.run("")
 
 
 def test_rollback_no_transaction(con):