Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Shuffle hook to support shuffle=yes from mpv options table (fixes #3950) #5024

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

svobs
Copy link
Contributor

@svobs svobs commented Jun 25, 2024


Description:

Adds explicit support for --shuffle=yes when supplied via the Additional mpv options table in Settings > Advanced.

As noted in this comment:

Fwiw, shuffle: yes WAS working for me, as of IINA for Mac 1.3.4, but it broke again in 1.3.5. :(

Analysis:

  1. PR Send directory arg to mpv instead of processing in IINA (fixes #4434) #4439 was the original attempt to add support for --mpv-shuffle arg via iina-cli. It was released in IINA 1.3.4. This also allowed --shuffle=yes via Settings > Advanced to work. But this introduced a regression: issue Opening folder spawns playlist that includes non-media files #4548
  2. PR Revert change to folder filtering + add special handling for shuffle arg instead (fixes regression: #4548) #4566 fixed the regression while adding support for --mpv-shuffle arg via iina-cli. This was in IINA 1.3.5. But it unfortunately broke support for --shuffle=yes via Settings > Advanced.
  3. This PR extends the previous PR to re-add support for --shuffle=yes using the improved solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant