Skip to content

Commit

Permalink
Add a potential problems check to make sure no .bazelversion is used.
Browse files Browse the repository at this point in the history
.bazelversion is a very crude bazel feature that does not support
semantic versioning, let alone version ranges. In combination with
baselisk, it even attempts to download binaries from the 'net instead
of using system-available versions.

Instead of pinning a bazel version, the repo should be kept in a state,
that it works with all actively maintained bazel versions.
  • Loading branch information
hzeller committed Dec 15, 2024
1 parent 3d821c6 commit a0a1d9c
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .github/bin/check-potential-problems.sh
Original file line number Diff line number Diff line change
Expand Up @@ -99,4 +99,9 @@ if [ $? -eq 0 ]; then
EXIT_CODE=1
fi

if [ -e .bazelversion ]; then
echo "Don't use .bazelversion. It is a poorly implemented bazel feature that does not support semantic versioning. Instead, make the repo work with all currently active bazel versions."
EXIT_CODE=1
fi

exit "${EXIT_CODE}"

0 comments on commit a0a1d9c

Please sign in to comment.