Make the 'rows must sum to 1' phrasing clearer (#530)

* Make the 'rows must sum to 1' phrasing clearer * Shorten line lengths
hmmlearn · Aug 31, 2023 · 23c0f13 · 23c0f13
1 parent e6a2447
commit 23c0f13
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/lib/hmmlearn/base.py b/lib/hmmlearn/base.py
@@ -546,9 +546,11 @@ def _check_sum_1(self, name):
         s = getattr(self, name).sum(axis=-1)
         if not np.allclose(s, 1):
             raise ValueError(
-                f"{name} must sum to 1 (got {s:.4f})" if s.ndim == 0 else
-                f"{name} rows must sum to 1 (got {s})" if s.ndim == 1 else
-                "Expected 1D or 2D array")
+                f"{name} must sum to 1 (got {s:.4f})"
+                if s.ndim == 0
+                else f"{name} rows must sum to 1 (got row sums of {s})"
+                    if s.ndim == 1
+                    else "Expected 1D or 2D array")
 
     def _check(self):
         """
@@ -929,9 +931,11 @@ def _check_sum_1(self, name):
         s = getattr(self, name).sum(axis=-1)
         if not np.allclose(s, 1):
             raise ValueError(
-                f"{name} must sum to 1 (got {s:.4f})" if s.ndim == 0 else
-                f"{name} rows must sum to 1 (got {s})" if s.ndim == 1 else
-                "Expected 1D or 2D array")
+                f"{name} must sum to 1 (got {s:.4f})"
+                if s.ndim == 0
+                else f"{name} rows must sum to 1 (got row sums of {s})"
+                    if s.ndim == 1
+                    else "Expected 1D or 2D array")
 
     def _check(self):
         """
@@ -1002,6 +1006,7 @@ def bic(self, X, lengths=None):
         n_params = sum(self._get_n_fit_scalars_per_param().values())
         return -2 * self.score(X, lengths=lengths) + n_params * np.log(len(X))
 
+
 _BaseHMM = BaseHMM  # Backcompat name, will be deprecated in the future.