Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add implementation for HazelcastCache #26434

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add implementation for HazelcastCache #26434

wants to merge 1 commit into from

Conversation

steinv
Copy link

@steinv steinv commented Oct 3, 2024

add implementation for HazelcastCache that overrides the Cache interterface default implementation

    @Nullable
    default CompletableFuture<?> retrieve(Object key) {
        throw new UnsupportedOperationException(this.getClass().getName() + " does not support CompletableFuture-based retrieval");
    }

@devOpsHazelcast
Copy link
Collaborator

devOpsHazelcast commented Oct 3, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@devOpsHazelcast
Copy link
Collaborator

Internal PR hazelcast/hazelcast-mono#3379
Internal message only. Nothing to see here, move along

@steinv steinv force-pushed the spring_cache_retrieve branch from ac69a19 to 58c5fb2 Compare October 3, 2024 14:09
@steinv steinv force-pushed the spring_cache_retrieve branch from 58c5fb2 to 44f5570 Compare October 3, 2024 14:10
@r1m
Copy link

r1m commented Oct 16, 2024

You should also implement the method with supplier
default <T> CompletableFuture<T> retrieve(Object key, Supplier<CompletableFuture<T>> valueLoader)

@r1m r1m mentioned this pull request Oct 16, 2024
Open
@fawazghali
Copy link
Member

fawazghali commented Nov 12, 2024 •
edited
Loading

We aim to merge this PR early next year. @TomaszGaweda @JamesHazelcast

@JamesHazelcast JamesHazelcast removed their request for review November 13, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmetmircik ahmetmircik Awaiting requested review from ahmetmircik

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@steinv @devOpsHazelcast @r1m @fawazghali