Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to HtmlUnit 3.9.0 or 4.1.0 #9958

Open
Lonzak opened this issue May 19, 2024 · 2 comments
Open

Upgrade to HtmlUnit 3.9.0 or 4.1.0 #9958

Lonzak opened this issue May 19, 2024 · 2 comments

Comments

@Lonzak
Copy link

Lonzak commented May 19, 2024 •
edited
Loading

Using GWT 2.10.1 (or 2.11.0 has the same issue).

The current version of htmlunit has a security vulnerability. Since it is a unit test it shouldn't be critical however tools report it so there is always a discussion with the security guys which could be avoided.

Note that there was a switch in the groupid (old , new . Changes can be found here)

We should upgrade to at least version 3.9.0 or higher:

<dependency>
    <groupId>org.htmlunit</groupId>
    <artifactId>htmlunit</artifactId>
    <version>4.1.0</version>
</dependency>

Please excuse my limited knowledge in GWT - but is htmlunit necessary during runtime?
@niloc132
Copy link
Contributor

Thanks for the report - but hopefully no one is using GWTTestCase to browse sites you don't control and trust?

No, htmlunit is present in gwt-dev, so only present during compilation or running tests, and only used to test your own test cases (and any page your test directs the simulated browser to).

@niloc132
Copy link
Contributor

When updating, we should also enable the fetch() polyfill https://htmlunit.sourceforge.io/webclient.html#Fetch_API_Polyfill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niloc132 @Lonzak