Skip to content

pycbc_coinc_findtrigs: is it an index issue? #5014

Closed
@yi-fan-wang

Description

In this https://github.com/gwastro/pycbc/blob/master/bin/all_sky_search/pycbc_coinc_findtrigs#L414 line of pycbc_coinc_findtrigs:

        tidx = len(threshes)
        for i in range(1, len(threshes)):
            if pivot_stat[-1] >= pivot_lower[kidx]:
                tidx = i
                break

It doesn't seem the expression after if changes at all as i iterates. So wouldn't i always be 1 if this condition is true?

I think kidx actually should be i

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions