Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Sync with upstream #2

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

chore: Sync with upstream #2

wants to merge 31 commits into from

Conversation

amccloud
Copy link

@amccloud amccloud commented Apr 28, 2021

What

For https://goabstract.atlassian.net/browse/ABS-5293

Pulling master down and merging package.json. Looks like most of the changes were minor bug fixes. One important change for us was updating context usage.

Part of https://app.abstract.com/projects/e3e69d60-8adc-4301-ad24-fbe7939b2275/notebooks/dcfd52d3-2d0d-4bfc-ba94-1613295eac90

Unfortunately, this PR does not quite get us to strict mode. react-sortable-hoc still use findDomNode and will likely continue to use it

New consumers are strongly encouraged to check out @dnd-kit before adopting this library in a new project. It supports all of the features of react-sortable-hoc, but with a more modern and extensible architecture.

This library will continue to receive critical updates and bug fixes for the foreseeable future, but there are no new features planned. In future versions of React, the findDOMNode method will be deprecated. This method is a critical piece of the architecture of react-sortable-hoc, and it's unlikely that the library could continue to exist with its current architecture once this method is deprecated. In light of this, all development efforts have been redirected towards @dnd-kit.

Clauderic Demers and others added 30 commits August 22, 2019 11:56
Bumps [markdown-to-jsx](https://github.com/probablyup/markdown-to-jsx) from 6.9.1 to 6.11.4.
- [Release notes](https://github.com/probablyup/markdown-to-jsx/releases)
- [Commits](quantizor/markdown-to-jsx@6.9.1...6.11.4)

Signed-off-by: dependabot[bot] <support@github.com>
Avoid issues on mobile where an error is triggered when calling
preventDefault on an event that cannot be cancelled.

Fix these kind of error messages:

[Intervention] Ignored attempt to cancel a touchmove event with
cancelable=false, for example because scrolling is in progress and
cannot be interrupted.
Add disableAutoscroll prop to SortableContainerProps
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](npm/ini@v1.3.5...v1.3.7)

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.4.1 to 6.5.4.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](indutny/elliptic@v6.4.1...v6.5.4)

Signed-off-by: dependabot[bot] <support@github.com>
Updates documentation for `shouldCancelStart` to indicate `button` types are also cancelled by default.
…scroll-key

fix: can't find key 'disableAutoscroll' in SortableContainerProps
fix: check if event is cancelable before calling preventDefault
…ode-issue

Fix touch events being lost by listening to event.target on mobile
Add react v17 to the peer deps.
…rn/elliptic-6.5.4

chore(deps): bump elliptic from 6.4.1 to 6.5.4
…rn/ini-1.3.7

chore(deps): bump ini from 1.3.5 to 1.3.7
…rn/markdown-to-jsx-6.11.4

chore(deps): bump markdown-to-jsx from 6.9.1 to 6.11.4
Bumps [bl](https://github.com/rvagg/bl) from 1.2.2 to 1.2.3.
- [Release notes](https://github.com/rvagg/bl/releases)
- [Commits](rvagg/bl@v1.2.2...v1.2.3)

Signed-off-by: dependabot[bot] <support@github.com>
…rn/bl-1.2.3

chore(deps): bump bl from 1.2.2 to 1.2.3
Fix shift to next row calculation
…rn/yargs-parser-5.0.1

chore(deps): bump yargs-parser from 5.0.0 to 5.0.1
New consumers are strongly encouraged to check out @dnd-kit before adopting this library in a new project. It supports all of the features of react-sortable-hoc, but with a more modern and extensible architecture.

This library will continue to receive critical updates and bug fixes for the foreseeable future, but there are no new features planned. In future versions of React, the findDOMNode method will be deprecated. This method is a critical piece of the architecture of react-sortable-hoc, and it's unlikely that the library could continue to exist with its current architecture once this method is deprecated. In light of this, all development efforts have been redirected towards @dnd-kit.
Bumps [y18n](https://github.com/yargs/y18n) from 3.2.1 to 3.2.2.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot[bot] <support@github.com>
…rn/y18n-3.2.2

chore(deps): bump y18n from 3.2.1 to 3.2.2
Bumps [ssri](https://github.com/npm/ssri) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/npm/ssri/releases)
- [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md)
- [Commits](npm/ssri@v6.0.1...v6.0.2)

Signed-off-by: dependabot[bot] <support@github.com>
…rn/ssri-6.0.2

chore(deps): bump ssri from 6.0.1 to 6.0.2
@amccloud amccloud requested review from tommoor and ossim April 28, 2021 17:20
@tommoor
Copy link

tommoor commented Apr 28, 2021

Is there a particular reason we're doing this now? eg the context usage was blocking something internally?

@amccloud
Copy link
Author

Copy link

@tommoor tommoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Have not tested installing this version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants