Merge pull request #4 from solidusio-contrib/allow_retries_to_be_disa…

…bled Allow Failed installments to not be reprocessed
ginlane · Feb 3, 2017 · da0931d · da0931d
2 parents 003cf2e + a745113
commit da0931d
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/apidoc/docs/configuration.md b/apidoc/docs/configuration.md
@@ -11,7 +11,8 @@ behaviour of the gem:
 SolidusSubscriptions::Config.default_gateway = my_gateway
 
 # Defines how long the system will wait before allowing a failed installment to
-# be reprocessed by the `Processor`
+# be reprocessed by the `Processor`. Set to nil to stop reprocessing failedx
+# installments
 SolidusSubscriptions::Config.reprocessing_interval = 1.days
 
 # Maximum number of times a user can skip their subscription before it

diff --git a/app/models/solidus_subscriptions/installment.rb b/app/models/solidus_subscriptions/installment.rb
@@ -119,6 +119,7 @@ def advance_actionable_date!
     end
 
     def next_actionable_date
+      return if Config.reprocessing_interval.nil?
       (DateTime.current + Config.reprocessing_interval).beginning_of_minute
     end
   end

diff --git a/spec/models/solidus_subscriptions/installment_spec.rb b/spec/models/solidus_subscriptions/installment_spec.rb
@@ -90,6 +90,22 @@
       actionable_date = installment.reload.actionable_date
       expect(actionable_date).to eq expected_date
     end
+
+    context 'the reprocessing interval is set to nil' do
+      around do |e|
+        interval, SolidusSubscriptions::Config.reprocessing_interval = [SolidusSubscriptions::Config.reprocessing_interval, nil]
+
+        e.run
+
+        SolidusSubscriptions::Config.reprocessing_interval = interval
+      end
+
+      it 'does not advance the installment actionable_date' do
+        subject
+        actionable_date = installment.reload.actionable_date
+        expect(actionable_date).to be_nil
+      end
+    end
   end
 
   describe '#unfulfilled?' do
-Original file line number
+Diff line change
@@ Expand Up / @@ -119,6 +119,7 @@ def advance_actionable_date! @@
         end
         def next_actionable_date
+          return if Config.reprocessing_interval.nil?
           (DateTime.current + Config.reprocessing_interval).beginning_of_minute
         end
       end
@@ Expand Down @@