Fix hashing of SCCs in dedupe #788
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We hash an SCC by concatenating the hashes of all the nodes. Previously we sorted the nodes by the hashes first, which meant two graphs with identical nodes would get the same hash, even if the edges were different. This commit changes the sorting to take topology into account, thereby fixing the bug.
Closed
This was referenced May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #787 to remove the extra commit
Fixes #748
We hash an SCC by concatenating the hashes of all the nodes. Previously
we sorted the nodes by the hashes first, which meant two graphs with
identical nodes would get the same hash, even if the edges were
different. This commit changes the sorting to take topology into
account, thereby fixing the bug.