Respect spotlight direction (#718)

Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
gazebosim · Mar 29, 2021 · 4ea1956 · 4ea1956
1 parent 14d967d
commit 4ea1956
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/Migration.md b/Migration.md
@@ -31,6 +31,11 @@ release will remove the deprecated code.
   * **Deprecated** `ignition::gazebo::gui::SnapPreviewPath`
   * **Replacement** `ignition::gui::SnapFromPath`
 
+* The `<direction>` tag of spot lights was previously not parsed by the
+  scene, so all spot lights shone in the direction corresponding to the
+  default `0 0 -1`. Since 5.x, the `<direction>` tag is correctly
+  processed.
+
 ## Ignition Gazebo 4.0.0 to 4.X.X
 
 * Ignition Gazebo 4.0.0 enabled double sided material by default but this

diff --git a/src/rendering/SceneManager.cc b/src/rendering/SceneManager.cc
@@ -1105,6 +1105,7 @@ rendering::LightPtr SceneManager::CreateLight(Entity _id,
       spotLight->SetInnerAngle(_light.SpotInnerAngle());
       spotLight->SetOuterAngle(_light.SpotOuterAngle());
       spotLight->SetFalloff(_light.SpotFalloff());
+      spotLight->SetDirection(_light.Direction());
       break;
     }
     case sdf::LightType::DIRECTIONAL: