[QtWebEngine] Silence cppcheck warning

fnkkio · Nov 28, 2019 · 0597fb7 · 0597fb7
1 parent 912c0ab
commit 0597fb7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/modules/backends/web/qtwebengine/QtWebEnginePage.cpp b/src/modules/backends/web/qtwebengine/QtWebEnginePage.cpp
@@ -337,19 +337,21 @@ QtWebEngineWebWidget* QtWebEnginePage::createWidget(SessionsManager::OpenHints h
 	return widget;
 }
 
-QString QtWebEnginePage::createJavaScriptList(QStringList rules) const
+QString QtWebEnginePage::createJavaScriptList(const QStringList &rules) const
 {
 	if (rules.isEmpty())
 	{
 		return {};
 	}
 
+	QStringList parsedRules(rules);
+
 	for (int i = 0; i < rules.count(); ++i)
 	{
-		rules[i].replace(QLatin1Char('\''), QLatin1String("\\'"));
+		parsedRules[i].replace(QLatin1Char('\''), QLatin1String("\\'"));
 	}
 
-	return QLatin1Char('\'') + rules.join(QLatin1String("','")) + QLatin1Char('\'');
+	return QLatin1Char('\'') + parsedRules.join(QLatin1String("','")) + QLatin1Char('\'');
 }
 
 QString QtWebEnginePage::createScriptSource(const QString &path, const QStringList &parameters) const

diff --git a/src/modules/backends/web/qtwebengine/QtWebEnginePage.h b/src/modules/backends/web/qtwebengine/QtWebEnginePage.h
@@ -63,7 +63,7 @@ class QtWebEnginePage final : public QWebEnginePage
 	void javaScriptConsoleMessage(JavaScriptConsoleMessageLevel level, const QString &note, int line, const QString &source) override;
 	QWebEnginePage* createWindow(WebWindowType type) override;
 	QtWebEngineWebWidget* createWidget(SessionsManager::OpenHints hints);
-	QString createJavaScriptList(QStringList rules) const;
+	QString createJavaScriptList(const QStringList &rules) const;
 	QStringList chooseFiles(FileSelectionMode mode, const QStringList &oldFiles, const QStringList &acceptedMimeTypes) override;
 	bool acceptNavigationRequest(const QUrl &url, QWebEnginePage::NavigationType type, bool isMainFrame) override;
 	bool javaScriptConfirm(const QUrl &url, const QString &message) override;