Consider adding driver_pod and executor_pod to the with_overrides method to maintain consistency with the constructor parameters.

Consider adding null checks for to_flyte_idl() calls on driver_pod and executor_pod to avoid potential NoneType errors.

The condition if "file" in path may match paths containing 'file' anywhere in the string, not just the protocol. Consider using if get_protocol(path) == "file" for more precise protocol checking.

The list of supported storage types support_types = ['s3', 'gs', 'abfs'] could be defined as a module-level constant since it's used for validation. Consider moving it outside the function to improve maintainability.

Consider using kwargs[_ANON] = anonymous instead of hardcoding True to maintain consistency with the input parameter value.

Consider validating the bucket parameter before passing it to get_async_filesystem_for_path(). An empty bucket could cause issues with certain storage backends. Similar issues were also found in:

• flytekit/core/data_persistence.py (line 318)
• flytekit/core/data_persistence.py (line 521)
• flytekit/core/data_persistence.py (line 308)

Consider extracting the bucket and path splitting logic into a separate method to improve code reusability and maintainability. The split_path function is used in multiple places and could be encapsulated better.

Consider handling the case where split_path() returns empty bucket for non-file protocols. Currently passing empty bucket to get_async_filesystem_for_path() could cause issues with cloud storage access.

Consider moving the fsspec implementation registrations to a more appropriate initialization location, such as a module-level __init__.py or a dedicated setup function. This would improve code organization and make the registrations more discoverable.

The mock_from_env assertion appears to be missing configuration parameters that were previously set for AWS HTTP connections and virtual hosted style requests. This could affect test coverage of S3 configuration behavior.

Consider consolidating the store creation functions into a single factory function to reduce code duplication. The current implementation has similar patterns repeated across s3store_from_env, gcsstore_from_env, and azurestore_from_env.

Consider passing the anonymous parameter to gcsstore_from_env() since it was previously used to set the token to _ANON when anonymous=True

Consider using direct function call parameters instead of unpacking store_kwargs to improve code readability and maintainability. The function call could be more explicit about what parameters are being passed.

The variable name '_FSSPEC_S3_SECRET' suggests a hardcoded password/secret. Consider using a more secure method of handling secrets.

The __init__ method only handles retries parameter but ignores validation of other important parameters like connect_timeout and read_timeout

Consider consolidating the blocksize property definition since it appears to be duplicated across multiple classes with the same value. Could potentially move this to a common base class or mixin.

The protocol tuple definition is missing parentheses which could lead to incorrect protocol handling. Consider adding parentheses: protocol = ("gcs", "gs")

Consider removing the duplicate **kwargs in the return statement since it's already included in azure_setup_args()

Consider handling GenericError separately from OSError since they may require different error handling approaches. The current implementation treats them the same way which could mask important error details.

The hardcoded timeout value of 999s in client_options may be too short for large data transfers. Consider making this configurable through environment variables or configuration settings.

The protocol assignment for ObstoreGCSFileSystem should be enclosed in parentheses to ensure it is a tuple.

The import statement from botocore.parsers import base64 seems incorrect. The base64 module is not part of botocore.parsers. Consider using Python's built-in base64 module instead.

The assertion in the test case for GCS storage options should include the token key with the value anon to ensure the anonymous parameter is correctly handled.

The version pinning of obstore to 0.3.0b10 might limit flexibility. Consider using a version range to allow for updates.

The function gcsstore_from_env is called without checking if the bucket parameter is valid or non-empty. Consider adding validation for the bucket parameter.

Consider adding error handling for the fsspec.register_implementation calls to ensure that any issues during registration are caught and handled appropriately.