Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When parsing flavors, handle Xcode build configurations that are not lowercase #161455

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

When parsing flavors, handle Xcode build configurations that are not lowercase #161455

wants to merge 1 commit into from
+70 −6

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jan 10, 2025

The flavors/Xcode build config/Xcode scheme matching logic tries to be permissive with casing. Instead of passing the lower-cased config into xcodebuild, instead pass the real scheme to get the right casing.

Fixes #85643

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added platform-ios iOS applications specifically a: existing-apps Integration with existing apps via the add-to-app flow labels Jan 10, 2025
@jmagman jmagman self-assigned this Jan 10, 2025
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 10, 2025
jmagman
jmagman commented Jan 10, 2025
View reviewed changes
packages/flutter_tools/test/general.shard/ios/xcodeproj_test.dart
@@ -964,6 +991,30 @@ Information about project "Runner":
),
'profile - Free',
);
expect(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On master this test fails:

          Expected: Profile-Paid
            Actual: Profile-paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jmagman jmagman

Labels
a: existing-apps Integration with existing apps via the add-to-app flow platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
1 participant
@jmagman