Introducing Mouse region config for RailDestination #161381
Conversation
github-actions
bot
added
framework
M97Chahboun
force-pushed
the
Add-MouseRegion-Support-to-NavigationRailDestination
branch
from
ff559b9 to
7888987
Compare
There was a problem hiding this comment.
Thanks for this contribution, including the documentation & test updates!
This looks to be an effective solution for #160834, but I am a bit concerned about the potential confusion between MouseRegion and MouseRegionConfig. I left a comment in the linked issue; in my opinion it'd be nice to have a more high-level discussion about which solution would be ideal before we move forward with this pull request.
|
|
||
| /// This data class is passed to [NavigationRail]'s [NavigationRailDestination] | ||
| /// through MouseRegion to configure the hover effect. | ||
| class MouseRegionConfig { |
There was a problem hiding this comment.
I feel a bit uneasy about the name "mouse region config", primarily because configuring a mouse region is what the existing MouseRegion widget already does, by definition.
If I understand correctly, this class is being introduced as a workaround, since a NavigationRailDestination isn't a widget and thus cannot be wrapped with a MouseRegion.
There was a problem hiding this comment.
Thank you @nate-thegrate
Yes, that's correct. I have created MouseRegionConfig to support all MouseRegion parameters. This approach ensures scalability and avoids breaking changes. Do you have any specific suggestions or feedback?
There was a problem hiding this comment.
As of now, I believe the best way to solve #160834 would be to rework the navigation rail destinations so it accepts a widget list. If you're interested in pursuing that, that'd be awesome, or feel free to let me know whatever thoughts you have about it :)
There was a problem hiding this comment.
I'll outline my implementation plan and would appreciate your feedback before I begin.
Please note that I believe this may result in a breaking change.
M97Chahboun
force-pushed
the
Add-MouseRegion-Support-to-NavigationRailDestination
branch
from
a5407b5 to
b79ee92
Compare
Closes #160834
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.